mirror of
https://github.com/serrebidev/BlindRSS.git
synced 2026-08-13 13:29:27 -07:00
Context menu in plain full‑text view is always displayed in English. #58
Labels
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
serrebi/BlindRSS#58
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Currently, when opening the context menu on a read‑only text field in the plain full‑text article view, the menu is displayed in English — regardless of the selected localization language in BlindRSS. This is the standard Windows system context menu for text input fields. The issue likely stems from a hardcoded English language setting for this UI element in the wxPython framework used by BlindRSS.
This inconsistency creates a poor user experience: users expect all interface elements to follow the application’s localization settings. Having an English‑only context menu contradicts the chosen language and may confuse non‑English‑speaking users.
Preconditions
Steps to reproduce
Actual behaviour
Expected behaviour
Technical notes
wx.TextCtrlwithwx.TE_READONLYstyle).Done in v1.107.0. Your technical read was right — and specifically, your second suggested solution is the one that works.
I did not go with
wx.Locale. Setting the app locale only helps if wx's own translation catalog for that language is present on the machine — that's shipped by wxWidgets, not by us, and we can't rely on it being installed. It would work on some machines and silently not on others, which is worse than a consistent bug. So the menu is now built from BlindRSS's own catalog, which always matches the app language by construction.One deviation from your expected behaviour, and I'd like your view on it. You listed "Cut, Copy, Paste, Select All". The reader is a read-only control, so Cut, Paste and Delete can only ever appear greyed out — the native menu shows them purely because it doesn't know the control is read-only. Arrowing past three dead items to reach the two live ones is noise for a screen-reader user, so the menu is:
If you'd rather it mirror the native menu exactly, with Cut/Paste present-but-disabled, say so and I'll change it.
Copy routes through the same code path as Ctrl+C, so the menu and the shortcut can't drift apart.
I agree that we only need these two items in the context menu.
But, unfortunately, I still have the standart, non-localizable context menu in BlindRSS 1.107.0.
It has seven options, always in English:
In BlindRSS version 1.107.2, the context menu now works as expected. I'm closing the issue. Thank you!